Clone Input when the workflow execution forks #5621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for your contribution @tovask ! :) |
Mzack9999
approved these changes
Sep 16, 2024
dogancanbakir
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Closes #5598
When the execution forks into multiple branches during a workflow, the subsequent subtemplates under a Matcher Name based condition check run with a new clone of the Input, so that they won't overwrite each other's extracted shared variables.
(This is not an issue when there are simle conditional subtemplates without a Matcher Name, because in that case the execution won't fork due to the slightly different logic. Though I'm not sure if this is intentional.)
Checklist